Modifications to Timing vs BX plot for ECAL (P5 Production version) #20256
Conversation
…re we have more statistics). For online DQM we modify the current binning to make it more useful to ECAL experts.
|
A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_9_2_X. It involves the following packages: DQM/EcalMonitorTasks @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: 21790d3 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
Hi @dmitrijus , I'm a little surprised some checks failed -- the problem log is here and this is the exception message: I'm not sure if there is a problem with the GT in the default runTheMatrix workflow, but in any case this PR only changes some local ECAL DQM code. (This PR has actually been deployed successfully already at P5.) |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Fill Timing vs BX plot with a much finer binning for offline DQM (where we have more statistics), to make it more useful for non-ECAL people. For online DQM we modify the current binning to make it more useful to ECAL experts.
Link to PR for CMSSW master: #20257
Link to corresponding P5 DQM GUI Deployment PR: dmwm/deployment#531