Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HCAL TP validation w/ premixing [92X] #20267

Merged
merged 2 commits into from Aug 31, 2017
Merged

Fix HCAL TP validation w/ premixing [92X] #20267

merged 2 commits into from Aug 31, 2017

Conversation

kpedro88
Copy link
Contributor

Backport of #20266

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Aug 24, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22475/console Started: 2017/08/24 20:32

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_2_X.

It involves the following packages:

Configuration/StandardSequences
SimCalorimetry/Configuration
SimGeneral/DataMixingModule

@cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

abort

@kpedro88
Copy link
Contributor Author

please test workflow 250207.17

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22478/console Started: 2017/08/24 20:42

@cmsbuild
Copy link
Contributor

+1
Tested at: 7f63a73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22478/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4258145
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22478/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22478/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22478/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1795532
  • DQMHistoTests: Total failures: 29335
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1766031
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88 kpedro88 mentioned this pull request Aug 25, 2017
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22525/console Started: 2017/08/28 16:23

@cmsbuild
Copy link
Contributor

Pull request #20267 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: a548fd4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22525/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f8281c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22525/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22525/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20267/22525/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1795498
  • DQMHistoTests: Total failures: 14905
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1780427
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor Author

@civanch @mdhildreth please sign

@civanch
Copy link
Contributor

civanch commented Aug 29, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88 kpedro88 changed the title Fix HCAL TP validation & packing w/ premixing [92X] Fix HCAL TP validation w/ premixing [92X] Aug 30, 2017
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 14aa96c into cms-sw:CMSSW_9_2_X Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpedro88 @cmsbuild @civanch @davidlange6