New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[93X] L1T Validation Module with GeneratorParticle Information: extend x-axis range for number of L1 objects hists #20312
Conversation
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @ly615 (Li Yuan) for master. It involves the following packages: Validation/L1T @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20312/387 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20312/387/git-diff.patch In future, you can run |
The code-checks are being triggered in jenkins. |
Pull request #20312 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
+code-checks |
The code-checks are being triggered in jenkins. |
Pull request #20312 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
+code-checks |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR makes two small fixes in Validation/L1T package which is used to fill the L1TriggerVsGen histograms for L1T RelVal:
fill the number of L1 objects when BX=0 instead of the size of BXVector.
extend the range of x axis for the L1 objects number histograms.
The PR has been tested with "runTheMatrix.py -l limited -i all", no problem shows up.