Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93X] L1T Validation Module with GeneratorParticle Information: extend x-axis range for number of L1 objects hists #20312

Merged
merged 3 commits into from Sep 4, 2017

Conversation

ly615
Copy link
Contributor

@ly615 ly615 commented Aug 30, 2017

This PR makes two small fixes in Validation/L1T package which is used to fill the L1TriggerVsGen histograms for L1T RelVal:
fill the number of L1 objects when BX=0 instead of the size of BXVector.
extend the range of x axis for the L1 objects number histograms.
The PR has been tested with "runTheMatrix.py -l limited -i all", no problem shows up.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ly615 (Li Yuan) for master.

It involves the following packages:

Validation/L1T

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20312/387

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20312/387/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20312/387/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #20312 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20312/392

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #20312 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20312/394

@rekovic
Copy link
Contributor

rekovic commented Sep 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22637/console Started: 2017/09/01 09:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20312/22637/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656041
  • DQMHistoTests: Total failures: 209
  • DQMHistoTests: Total nulls: 23
  • DQMHistoTests: Total successes: 2655620
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7a9b34f into cms-sw:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants