New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic of L3 muon filters when matching to previous candidates is not required #20333
Conversation
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @sarafiorendi for master. It involves the following packages: HLTrigger/Muon @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
[backport of #20333] Fix logic of L3 muon filters when matching to previous candidates is not required
Fix the logic of the L3 filters when the parameter "MatchToPreviousCand" is set to False.
In the current HLT menu this parameter is always True, therefore the fix will be transparent.
In the current version of the filters, no muon candidate is passed through the selection procedure (kinematic and quality requirements) if the matching is de-activated, while the correct logic is to pass all the muon candidates. This PR fix this issue.