limited:: module types #20358
limited:: module types #20358
Conversation
Fix the case where the service seg faults when it is destroyed because an exception happens during configuration time.
Added limited module type and unit tests. The limited module type is similar to a global module (and uses the same interface) except one specifies in its configuration how many concurrent threads are allowed to call the module.
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20358/470 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20358/470/git-diff.patch You can run |
|
@dan131riley here is the new module type intended to be used for your new implemention of the PoolOutputModule. |
|
Many of the 'code checks' are already in #20327. I'd rather wait for that one to be merged and then do a rebase of this pull request. update: Only Worker.h overlaps with the earler pull request. I applied all but the Worker.h changes to this pull request. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-rejected
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
Pull request #20358 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
+code-checks |
|
please abort |
|
type new-feature |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
yes, lets save this for 94X |
|
For the ParallelPoolOutputModule I believe this will need implementations of subProcessParentageHelper() and non-placeholder preActionBeforeRunEventAsync(). These, of course, can be done later, and are trivial to copy from the one::OutputModuleBase. |
|
merge |
An edm::limited module is similar to an edm::global module (they share the same interface design), however in the edm::limited module's configuration you specify how many concurrent threads are allowed to call the module at any instance in time.