Small miniAOD improvements #20367

gpetruc · 2017-09-04T12:26:12Z

add a missing const in the miniPFIsolation method declaration
save dz(PV) into the pat Electron & Muon for convenience of applying it downstream without a PV object, e.g. via string-based selectors (we already do that dxy(PV) and ip3d(PV))
add non-templated reduceMantissaToNbits methods with rounding

will push the code-checks to this branch later (to not obscure the content of the PR)

@arizzi @peruzzim @emanueledimarco

…t for bulk conversion via std::transform

slava77 · 2017-09-04T12:47:18Z

@smuzaffar
has the bot fallen asleep?
It's been 20 mins since the PR was submitted and the bot did not register it yet.

cmsbuild · 2017-09-04T13:13:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-04T13:13:34Z

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-09-04T13:16:15Z

please test

cmsbuild · 2017-09-04T13:18:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22690/console Started: 2017/09/04 15:23

cmsbuild · 2017-09-04T13:31:56Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20367/485

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20367/485/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20367/485/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

slava77 · 2017-09-04T13:54:07Z

DataFormats/PatCandidates/interface/libminifloat.h

+        class ReduceMantissaToNbitsRounding {
+            public:
+                ReduceMantissaToNbitsRounding(int bits) : 
+                    shift(23-bits), mask((0xFFFFFFFF >> (shift)) << (shift)), 


it looks like this duplicates the functionality of inline static float reduceMantissaToNbitsRounding(const float &f)
please remove the other implementation or see how the code duplication can be reduced

is the solution in 9f31d22 ok for you?

yes, it looks OK.
Thank you.

cmsbuild · 2017-09-04T14:52:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-04T14:52:51Z

Pull request #20367 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

cmsbuild · 2017-09-04T14:55:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20367/488

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20367/488/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20367/488/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

cmsbuild · 2017-09-06T16:13:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-06T16:13:46Z

Pull request #20367 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

slava77 · 2017-09-06T16:14:05Z

@cmsbuild please test

cmsbuild · 2017-09-06T16:14:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22757/console Started: 2017/09/06 18:15

cmsbuild · 2017-09-06T16:15:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20367/534

cmsbuild · 2017-09-06T18:36:37Z

+1
Tested at: c5e1951
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20367/22757/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b9e4992
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20367/22757/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20367/22757/git-merge-result

cmsbuild · 2017-09-06T18:36:39Z

Comparison job queued.

cmsbuild · 2017-09-06T19:29:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20367/22757/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2656498
DQMHistoTests: Total failures: 208
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2656101
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

slava77 · 2017-09-06T20:06:21Z

DataFormats/PatCandidates/interface/Lepton.h

@@ -193,7 +193,7 @@ namespace pat {
      void hcalIsoDeposit(const IsoDeposit &dep)  { setIsoDeposit(pat::HcalIso, dep); }
      void userIsoDeposit(const IsoDeposit &dep, uint8_t index=0) { setIsoDeposit(IsolationKeys(UserBaseIso + index), dep); }

-      const PFIsolation& miniPFIsolation() { return miniPFIsolation_; }
+      const PFIsolation& miniPFIsolation() const { return miniPFIsolation_; }


please make a backport for this part to 93X and 92X.

gpetruc · 2017-09-07T08:43:24Z

ok will do tomorrow Il 06 Set 2017 22:06, "Slava Krutelyov" <notifications@github.com> ha scritto:

…

***@***.**** commented on this pull request. ------------------------------ In DataFormats/PatCandidates/interface/Lepton.h <#20367 (comment)>: > @@ -193,7 +193,7 @@ namespace pat { void hcalIsoDeposit(const IsoDeposit &dep) { setIsoDeposit(pat::HcalIso, dep); } void userIsoDeposit(const IsoDeposit &dep, uint8_t index=0) { setIsoDeposit(IsolationKeys(UserBaseIso + index), dep); } - const PFIsolation& miniPFIsolation() { return miniPFIsolation_; } + const PFIsolation& miniPFIsolation() const { return miniPFIsolation_; } please make a backport for this part to 93X and 92X. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20367 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEbbR38MdTq3OhU1gECZ1uP0KhH4SrH7ks5sfvs_gaJpZM4PL2ox> .

slava77 · 2017-09-07T13:34:49Z

+1

for #20367 d5d893e

changes are as described; one float is added to pat electrons and muons, other changes are somewhat more technical.
jenkins tests pass and comparisons with baseline show no differences

davidlange6 · 2017-09-08T17:22:13Z

merge

gpetruc added 3 commits September 4, 2017 13:34

PatCandidates Lepton.h : make the miniPFIsolation() const

863334d

add dZ from PV to PAT Electron & Muon

68f737b

Add non-templated version of reduceMantissaToNbitsRounding and suppor…

78b19b4

…t for bulk conversion via std::transform

cmsbuild added this to the CMSSW_9_3_X milestone Sep 4, 2017

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 4, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 4, 2017

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 4, 2017

slava77 reviewed Sep 4, 2017

View reviewed changes

remove code duplication

9f31d22

cmsbuild added code-checks-pending tests-pending and removed code-checks-rejected tests-started labels Sep 4, 2017

cmsbuild added code-checks-pending comparison-pending tests-pending labels Sep 6, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 6, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2017

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2017

cmsbuild added comparison-available and removed comparison-pending labels Sep 6, 2017

slava77 reviewed Sep 6, 2017

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 7, 2017

This was referenced Sep 8, 2017

PatCandidates Lepton.h : make the miniPFIsolation() const #20431

Merged

PatCandidates Lepton.h : make the miniPFIsolation() const (93X) #20432

Merged

cmsbuild merged commit 9617bdf into cms-sw:master Sep 8, 2017

gpetruc added a commit to gpetruc/NanoAOD that referenced this pull request Sep 13, 2017

workaround for dz on 92X (requires a 94X IB with cms-sw/cmssw#20367)

ef63009

silviodonato mentioned this pull request Apr 27, 2020

Improvements of ReduceMantissaToNbitsRounding #29564

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small miniAOD improvements #20367

Small miniAOD improvements #20367

gpetruc commented Sep 4, 2017

slava77 commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017 •

edited

cmsbuild commented Sep 4, 2017

slava77 Sep 4, 2017

gpetruc Sep 4, 2017

slava77 Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

slava77 commented Sep 6, 2017

cmsbuild commented Sep 6, 2017 •

edited

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

slava77 Sep 6, 2017

gpetruc commented Sep 7, 2017 via email

slava77 commented Sep 7, 2017

davidlange6 commented Sep 8, 2017

Small miniAOD improvements #20367

Small miniAOD improvements #20367

Conversation

gpetruc commented Sep 4, 2017

slava77 commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

perrotta commented Sep 4, 2017

cmsbuild commented Sep 4, 2017 • edited

cmsbuild commented Sep 4, 2017

slava77 Sep 4, 2017

Choose a reason for hiding this comment

gpetruc Sep 4, 2017

Choose a reason for hiding this comment

slava77 Sep 4, 2017

Choose a reason for hiding this comment

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

slava77 commented Sep 6, 2017

cmsbuild commented Sep 6, 2017 • edited

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

cmsbuild commented Sep 6, 2017

slava77 Sep 6, 2017

Choose a reason for hiding this comment

gpetruc commented Sep 7, 2017 via email

slava77 commented Sep 7, 2017

davidlange6 commented Sep 8, 2017

cmsbuild commented Sep 4, 2017 •

edited

cmsbuild commented Sep 6, 2017 •

edited