consumes migration for several packages #2037

deguio · 2014-01-15T19:57:51Z

fixing previous pulls

cmsbuild · 2014-01-15T19:58:04Z

A new Pull Request was created by @deguio for CMSSW_7_0_X.

consumes migration for several packages

It involves the following packages:

DQM/SiStripCommon
DQMOffline/Alignment
DQMOffline/EGamma

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

cmsbuild · 2014-01-16T10:39:33Z

-1
I found an error when building:

>> Building edm plugin tmp/slc5_amd64_gcc481/src/DQMServices/Core/test/DQMServicesCoreROOTQTestsExample/libDQMServicesCoreROOTQTestsExample.so
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lRecoJetsJetProducers
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lSimDataFormatsCaloHit
Leaving library rule at src/DQMServices/Core/test
>> Building edm plugin tmp/slc5_amd64_gcc481/src/DQMServices/Core/test/DQMTestMultiThread/libDQMTestMultiThread.so
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc5_amd64_gcc481/src/DQMServices/Examples/src/DQMServicesExamples/libDQMServicesExamples.so] Error 1
gmake: **\* Waiting for unfinished jobs....
Leaving library rule at src/DQMServices/Core/test
Leaving library rule at src/DQMServices/Core/test
Leaving library rule at src/DQMServices/Core/test

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2037/2100/summary.html

deguio · 2014-01-16T11:23:45Z

@cmsbuild
not sure about the compilation errors. it is not related to the pull itself and it is happening in CMSSW_7_0_X_2014-01-16-0200 only. everything seems to build fine on top of CMSSW_7_0_X_2014-01-15-0200.
what I am missing?

cmsbuild · 2014-01-16T11:25:31Z

-1
When I ran the RelVals I found an error in the following worklfows:
1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 16-Jan-2014 12:10:30 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Calling beginJob for module TkAlCaRecoMonitor/'ALCARECOTkAlMinBiasTkAlDQM'
Exception Message:
A module declared it consumes a product after its constructor.
This must be done in the contructor
The product type was: std::vector
and InputTag:  label = ALCARECOTkAlMinBias, instance = 
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 16-Jan-2014 12:10:32 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Calling beginJob for module TkAlCaRecoMonitor/'ALCARECOTkAlZMuMuTkAlDQM'
Exception Message:
A module declared it consumes a product after its constructor.
This must be done in the contructor
The product type was: std::vector
and InputTag:  label = ALCARECOTkAlZMuMu, instance = 
----- End Fatal Exception -------------------------------------------------

4.22 step3

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step3_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 16-Jan-2014 12:11:35 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Calling beginJob for module TkAlCaRecoMonitor/'ALCARECOTkAlCosmicsCTF0TTkAlDQM'
Exception Message:
A module declared it consumes a product after its constructor.
This must be done in the contructor
The product type was: std::vector
and InputTag:  label = ALCARECOTkAlCosmicsCTF0T, instance = 
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 16-Jan-2014 12:14:02 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Calling beginJob for module TkAlCaRecoMonitor/'ALCARECOSiStripCalMinBiasTrackerDQM'
Exception Message:
A module declared it consumes a product after its constructor.
This must be done in the contructor
The product type was: std::vector
and InputTag:  label = ALCARECOSiStripCalMinBias, instance = 
----- End Fatal Exception -------------------------------------------------

25.0 step5

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step5_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 16-Jan-2014 12:25:14 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Calling beginJob for module TkAlCaRecoMonitor/'ALCARECOTkAlMuonIsolatedTkAlDQM'
Exception Message:
A module declared it consumes a product after its constructor.
This must be done in the contructor
The product type was: std::vector
and InputTag:  label = ALCARECOTkAlMuonIsolated, instance = 
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2037/2107/summary.html

ktf · 2014-01-16T12:24:02Z

Indeed CMSSW_7_0_X_2014-01-16-0200 is broken. :-/ We have a fix and
next IB should be fine.

On 16 Jan 2014, at 12:23, deguio wrote:

@cmsbuild
not sure about the compilation errors. it is not related to the pull
itself and it is happening in CMSSW_7_0_X_2014-01-16-0200 only.
everything seems to build fine on top of CMSSW_7_0_X_2014-01-15-0200.
what I am missing?

Reply to this email directly or view it on GitHub:
#2037 (comment)

cmsbuild · 2014-01-16T12:43:17Z

Pull request #2037 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

cmsbuild · 2014-01-17T11:28:33Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2037/2119/summary.html

deguio · 2014-01-20T13:44:05Z

+1

cmsbuild · 2014-01-20T13:48:04Z

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf · 2014-01-20T15:30:28Z

Can I ask you to open a pull request to 71X?

deguio · 2014-01-20T15:37:27Z

yep, done.
ciao,
F.

davidlange6 · 2014-01-22T14:07:35Z

+1

ktf · 2014-01-23T11:12:18Z

@davidlange6 why do you want this in 70X?

DQM fixes -- Consumes migration for several packages

upgrade lhapdfsets to 6.1.5f

batinkov and others added 11 commits January 13, 2014 07:50

getByLabel -> getByToken

d666df3

getByLabel -> getByToken

022e65c

getByLabel -> getByToken for ElectronAnalyzer

d87f8d4

getByLabel -> getByToken for ElectronGeneralAnalyzer

8e01fda

getByLabel -> getByToken for ElectronTagProbeAnalyzer

94ef057

The comments are removed.

d7f7dfd

The commented code is removed.

d1b1ec9

Merged refs/pull/2019/head from repository cms-sw

e68f402

Merged refs/pull/2017/head from repository cms-sw

8bc86f7

Merged refs/pull/2020/head from repository cms-sw

9cdb546

consumes migration

b9e27a1

Merged refs/pull/2037/head from repository cms-sw

989751b

moving consumes declaration in the constructor

a9fe95e

ktf added a commit that referenced this pull request Jan 27, 2014

Merge pull request #2037 from deguio/fixingAtanasPulls

8a12a98

DQM fixes -- Consumes migration for several packages

ktf merged commit 8a12a98 into cms-sw:CMSSW_7_0_X Jan 27, 2014

nclopezo modified the milestones: CMSSW_7_0_0, CMSSW_7_0_0_pre13 Feb 7, 2014

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017

Merge pull request cms-sw#2037 from mkirsano/tolhapdfsets615f

008c120

upgrade lhapdfsets to 6.1.5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

consumes migration for several packages #2037

consumes migration for several packages #2037

deguio commented Jan 15, 2014

cmsbuild commented Jan 15, 2014

cmsbuild commented Jan 16, 2014

deguio commented Jan 16, 2014

cmsbuild commented Jan 16, 2014

ktf commented Jan 16, 2014

cmsbuild commented Jan 16, 2014

cmsbuild commented Jan 17, 2014

deguio commented Jan 20, 2014

cmsbuild commented Jan 20, 2014

ktf commented Jan 20, 2014

deguio commented Jan 20, 2014

davidlange6 commented Jan 22, 2014

ktf commented Jan 23, 2014

consumes migration for several packages #2037

consumes migration for several packages #2037

Conversation

deguio commented Jan 15, 2014

cmsbuild commented Jan 15, 2014

cmsbuild commented Jan 16, 2014

deguio commented Jan 16, 2014

cmsbuild commented Jan 16, 2014

ktf commented Jan 16, 2014

cmsbuild commented Jan 16, 2014

cmsbuild commented Jan 17, 2014

deguio commented Jan 20, 2014

cmsbuild commented Jan 20, 2014

ktf commented Jan 20, 2014

deguio commented Jan 20, 2014

davidlange6 commented Jan 22, 2014

ktf commented Jan 23, 2014