Phase-1 interface to store L1 CSC TPG params in DB #20375

dildick · 2017-09-04T23:11:36Z

The Phase-1 upgrade of CSC TPG includes new ALCT, CLCT and TMB algorithms for ME1/1. Setters and getters were added to update the params in the DB. Clarification: CSCs other than ME1/1 will not be upgraded for Phase-1. ME2/1, ME3/1 and ME4/1 will also be upgraded for Phase-2 (not included in this pull request).

cmsbuild · 2017-09-04T23:11:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-04T23:11:59Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

CondFormats/CSCObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-09-04T23:13:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20375/494

davidlange6 · 2017-09-05T00:42:48Z

please test

cmsbuild · 2017-09-05T00:43:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22705/console Started: 2017/09/05 05:37

cmsbuild · 2017-09-05T04:34:45Z

-1

Tested at: 1f97549

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d2769e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/22705/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/22705/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/22705/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testSerializationCSCObjects had ERRORS

RelVals:

When I ran the RelVals I found an error in the following worklfows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:18:58 2017-date Tue Sep 5 06:13:17 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:18:57 2017-date Tue Sep 5 06:13:20 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v30.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:26:11 2017-date Tue Sep 5 06:13:23 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:23:46 2017-date Tue Sep 5 06:13:26 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:23 2017-date Tue Sep 5 06:13:31 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:26:21 2017-date Tue Sep 5 06:13:35 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:22:09 2017-date Tue Sep 5 06:13:44 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:23:09 2017-date Tue Sep 5 06:13:47 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v30.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:19 2017-date Tue Sep 5 06:13:50 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:23:55 2017-date Tue Sep 5 06:13:55 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v21.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:07 2017-date Tue Sep 5 06:13:57 2017 s - exit: 16640
cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Sep 5 06:21:19 2017-date Tue Sep 5 06:14:00 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:26:23 2017-date Tue Sep 5 06:14:01 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:14 2017-date Tue Sep 5 06:14:06 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v21.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:26:03 2017-date Tue Sep 5 06:14:07 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:30:46 2017-date Tue Sep 5 06:14:10 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:42 2017-date Tue Sep 5 06:14:12 2017 s - exit: 16640
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Tue Sep 5 06:24:00 2017-date Tue Sep 5 06:14:17 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:24:00 2017-date Tue Sep 5 06:14:17 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:21:40 2017-date Tue Sep 5 06:14:18 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:23:49 2017-date Tue Sep 5 06:14:22 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02488/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-09-04-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Sep 5 06:23:16 2017-date Tue Sep 5 06:14:27 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d2769e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/22705/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/22705/git-merge-result

cmsbuild · 2017-09-05T04:34:48Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

ggovi · 2017-09-05T08:44:46Z

@dildick
you are adding data members to the class CSCDBL1TPParameters
This class has been used in the past for populating tags included in production GTs ( 71 and 74 series ).
Altering the 'shape' would potentially generates mismatches between reader version and stored payload version, and it should be avoided.
I would recommend to create a new CondFormat class having the new attributes.

dildick · 2017-09-05T13:54:36Z

@ggovi You want me to leave CSCDBL1TPParameters untouched, and instead make a class
CSCDBL1TPPhase1Parameters for the phase-1 CSC upgrade? In the far future, the CSC OTMB will be upgraded again and GEM parameters will enter the game. Should we then construct a class CSCDBL1TPPhase2Parameters?

dildick · 2017-09-06T16:00:55Z

@slava77 what is your take on this? Should we extend the current CSCDBL1TPParameters or make a version of phase-1 upgrade CSCDBL1TPPhase1Parameters?

davidlange6 · 2017-09-06T16:11:31Z

hi @dildick - just to clarify- you are not allowed to schema evolve conditions database objects, eg, CondFormats (per policy of alca/db)

cmsbuild · 2017-12-15T14:54:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25121/console Started: 2017/12/15 18:09

cmsbuild · 2017-12-15T14:54:01Z

Pull request #20375 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please check and sign again.

ghellwig · 2017-12-15T15:28:33Z

+1
provided jenkins agrees

cmsbuild · 2017-12-15T18:30:43Z

+1
Tested at: fffdd18
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/25121/summary.html

cmsbuild · 2017-12-15T18:30:46Z

Comparison job queued.

cmsbuild · 2017-12-15T21:13:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20375/25121/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-20375/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2836825
DQMHistoTests: Total failures: 2097
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2834550
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.990000000078 KiB( 23 files compared)
Checked 113 log files, 9 edm output root files, 27 DQM output files

dildick · 2017-12-18T16:29:09Z

Are there any more comments?

dildick · 2017-12-18T18:45:26Z

@ggovi can you please sign again?

ggovi · 2017-12-19T15:31:23Z

+1

cmsbuild · 2017-12-19T15:32:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-12-19T20:16:43Z

+1

cmsbuild added this to the CMSSW_9_3_X milestone Sep 4, 2017

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Sep 4, 2017

dildick mentioned this pull request Sep 4, 2017

Modifier for high-lumi CSC L1 local trigger algorithms #20249

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 4, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 5, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Sep 5, 2017

smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_9_3_X Sep 6, 2017

cmsbuild added the code-checks-approved label Dec 15, 2017

cmsbuild added tests-started and removed tests-pending labels Dec 15, 2017

cmsbuild added alca-approved and removed alca-pending labels Dec 15, 2017

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2017

cmsbuild added comparison-available and removed comparison-pending labels Dec 15, 2017

dildick closed this Dec 18, 2017

dildick reopened this Dec 18, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Dec 19, 2017

cmsbuild added orp-approved and removed orp-pending labels Dec 19, 2017

cmsbuild merged commit cdd3b38 into cms-sw:master Dec 19, 2017

dildick deleted the from-CMSSW_9_3_X_2017-08-30-2300-csc-cond-l1-trigger branch December 23, 2017 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase-1 interface to store L1 CSC TPG params in DB #20375

Phase-1 interface to store L1 CSC TPG params in DB #20375

dildick commented Sep 4, 2017 •

edited

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

davidlange6 commented Sep 5, 2017

cmsbuild commented Sep 5, 2017 •

edited

cmsbuild commented Sep 5, 2017

cmsbuild commented Sep 5, 2017

ggovi commented Sep 5, 2017

dildick commented Sep 5, 2017

dildick commented Sep 6, 2017

davidlange6 commented Sep 6, 2017

cmsbuild commented Dec 15, 2017 •

edited

cmsbuild commented Dec 15, 2017

ghellwig commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

dildick commented Dec 18, 2017

dildick commented Dec 18, 2017

ggovi commented Dec 19, 2017

cmsbuild commented Dec 19, 2017

davidlange6 commented Dec 19, 2017

Navigation Menu

Phase-1 interface to store L1 CSC TPG params in DB #20375

Phase-1 interface to store L1 CSC TPG params in DB #20375

Conversation

dildick commented Sep 4, 2017 • edited

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

cmsbuild commented Sep 4, 2017

davidlange6 commented Sep 5, 2017

cmsbuild commented Sep 5, 2017 • edited

cmsbuild commented Sep 5, 2017

cmsbuild commented Sep 5, 2017

ggovi commented Sep 5, 2017

dildick commented Sep 5, 2017

dildick commented Sep 6, 2017

davidlange6 commented Sep 6, 2017

cmsbuild commented Dec 15, 2017 • edited

cmsbuild commented Dec 15, 2017

ghellwig commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

dildick commented Dec 18, 2017

dildick commented Dec 18, 2017

ggovi commented Dec 19, 2017

cmsbuild commented Dec 19, 2017

davidlange6 commented Dec 19, 2017

dildick commented Sep 4, 2017 •

edited

cmsbuild commented Sep 5, 2017 •

edited

cmsbuild commented Dec 15, 2017 •

edited