Updated vbf filter v2 #20394
Updated vbf filter v2 #20394
Conversation
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @gmandorl for master. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| inputTag_GenJetCollection = cms.untracked.InputTag('ak4GenJetsNoNu'), | ||
|
|
||
| leadJetsNoLepMass = cms.untracked.bool ( True), # Require the cut on the mass of the leading jets |
There was a problem hiding this comment.
this should probably be False
There was a problem hiding this comment.
not true, should be True...
Does it work if leadJetsNoLepMass and the other parameters are not specified?
There was a problem hiding this comment.
If leadJetsNoLepMass is true but no other parameters are specified the code works.
In that case, the events pass the selection whenever there are at least two jets with DR > 0.3 from all the charged hard leptons.
There was a problem hiding this comment.
If leadJetsNoLepMass is not specified, it is set as false
|
+1 |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
I updated VBFGenJetFilter.cc in both the pull requests. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
VBFGenJetFilter.cc has been extended.
Possible requirements on the invariant mass of the two pt-leading genjets.
The considered genjets can also be asked to have a minimum DR from the event charged prompt leptons.