Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal pedestal pcl fixes 92x v2 #20418

Merged
merged 6 commits into from Sep 11, 2017

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Sep 7, 2017

replaces #20369

 fix for Nans, added histos, added check, added exclusion of non-stable beam

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

A new Pull Request was created by @argiro for CMSSW_9_2_X.

It involves the following packages:

Calibration/EcalCalibAlgos
Configuration/PyReleaseValidation

@ghellwig, @kkousour, @arunhep, @cerminar, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @tocheng, @Martin-Grunewald, @mmusich, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Sep 7, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22795/console Started: 2017/09/08 01:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20418/22795/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904642
  • DQMHistoTests: Total failures: 29288
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1875180
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

+1

@fabozzi
Copy link
Contributor

fabozzi commented Sep 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Pull request #20418 was updated. @ghellwig, @kkousour, @arunhep, @cerminar, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @lpernie can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22827/console Started: 2017/09/09 00:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20418/22827/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904710
  • DQMHistoTests: Total failures: 29865
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1874671
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 11, 2017

+1

@fabozzi
Copy link
Contributor

fabozzi commented Sep 11, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit cd78fdb into cms-sw:CMSSW_9_2_X Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants