Allow edm::soa::Table<> as a data product #20425
Conversation
Fixed type mismatch problems when calling const versions of begin() and end().
Classes with a 'const char* const' template parameter can not be used outside of their 'compilation unit' in gcc. This is enforced by having std::type_info's not be comparable across the units. This required a rework for edm::soa::Column so now a column is an object that inherits from edm::soa::Column and has a static member declaring kLabel.
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/TestObjects @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
+code-checks |
cmsbuild
added
code-checks-approved
core-approved
fully-signed
and removed
code-checks-pending
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Fixed problems that were making it impossible to sue an edm::soa::Table<> as a data product.
Included an integration test which uses an edm::soa::Table<> as a data product.