Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca94 Add a new method to compute energy sum of ECAL towers preceding a HCAl cell… #20427

Merged
merged 2 commits into from Sep 12, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 7, 2017

This method is useful in finding MIP signal in HE in regions not covered by Tracker

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/IsolatedParticles

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20427/573

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 7, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22799/console Started: 2017/09/08 01:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20427/22799/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 207
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642044
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20427/625

@cmsbuild
Copy link
Contributor

Pull request #20427 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22863/console Started: 2017/09/11 17:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20427/22863/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2563849
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2563461
  • DQMHistoTests: Total skipped: 186
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@bsunanda
Copy link
Contributor Author

@arunhep Can you approve this again?

@lpernie
Copy link
Contributor

lpernie commented Sep 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6ebb129 into cms-sw:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants