New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor track MVA classifier code #20429
Conversation
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQM/Integration @perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
1f89b26
to
2baf7a6
Compare
The code-checks are being triggered in jenkins. |
Pull request #20429 was updated. @perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please check and sign again. |
+code-checks |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
Pull request #20429 was updated. @perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please check and sign again. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Currently the base class of track MVA (and cut) classifiers obtaines the
GBRForest
object. But the existing cut-based classifier or any possible future non-BDT classifier should not have to care aboutGBRForest, so this PR refactors the MVA classifier classes by moving all
GBRForestvariables to the
MVAtemplate argument of
TrackMVAClassifier`.Tested in CMSSW_9_3_X_2017-09-06-1100 (rebased on top of CMSSW_9_4_X_2017-09-15-1100), no changes expected.
@rovere @VinInn @hajohajo @felicepantaleo