Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor track MVA classifier code #20429

Merged
merged 2 commits into from Sep 20, 2017
Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 8, 2017

Currently the base class of track MVA (and cut) classifiers obtaines the GBRForest object. But the existing cut-based classifier or any possible future non-BDT classifier should not have to care about GBRForest, so this PR refactors the MVA classifier classes by moving all GBRForestvariables to theMVAtemplate argument ofTrackMVAClassifier`.

Tested in CMSSW_9_3_X_2017-09-06-1100 (rebased on top of CMSSW_9_4_X_2017-09-15-1100), no changes expected.

@rovere @VinInn @hajohajo @felicepantaleo

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/Integration
HLTrigger/Configuration
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @batinkov, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @jalimena, @mschrode, @thomreis, @gpetruc, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Pull request #20429 was updated. @perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20429/576

@makortel
Copy link
Contributor Author

makortel commented Sep 8, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22804/console Started: 2017/09/08 10:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20429/577

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20429/22804/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 215
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642036
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23014/console Started: 2017/09/15 21:30

@cmsbuild
Copy link
Contributor

Pull request #20429 was updated. @perrotta, @cmsbuild, @vazzolini, @kmaeshima, @fwyzard, @dmitrijus, @Martin-Grunewald, @silviodonato, @slava77, @vanbesien can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20429/23014/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646476
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

+1

  • Code does what it says
  • No effect o jenkins outputs, as expected
  • Modifications observed in Pixel Phase1 TackingParticles in the MC DQM are due to non reproducibilities already observed in different PRs, see Refactor track MVA classifier code #20429 (comment)

@Martin-Grunewald
Copy link
Contributor

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants