Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix muon hit related info #20434

Merged
merged 2 commits into from Sep 12, 2017
Merged

Conversation

swagata87
Copy link
Contributor

Currently, the variable nMatchedStations is set to zero. And number of valid muon hits is accessed in a way that it always returns zero. As these 2 variables will be essential for the analysis that we plan to do using the dimuon scouting data, so I changed the code in a way that these variables returns meaningful value and save that in the event.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

We'd need a 94X PR for integration first!

@swagata87
Copy link
Contributor Author

Ok, I created another PR for 94X here-> #20441

@Martin-Grunewald
Copy link
Contributor

Please apply the scram build code checks fro the 94X PR also here!

@cmsbuild
Copy link
Contributor

Pull request #20434 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22879/console Started: 2017/09/12 09:23

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20434/22879/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904608
  • DQMHistoTests: Total failures: 29691
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1874743
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ebdcca8 into cms-sw:CMSSW_9_2_X Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants