Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates in relvals #20461

Merged
merged 4 commits into from Sep 15, 2017
Merged

updates in relvals #20461

merged 4 commits into from Sep 15, 2017

Conversation

prebello
Copy link
Contributor

this PR aims to:

  • include the new premix relval SMS-T1tttt_mG1-1500_mLSP-100_13
  • adjust few jobs splitting and
  • update the regenerated GENSIM from 9_3_0_pre5

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Sep 11, 2017
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20461/628

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @prebello (Patricia Rebello Teles) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @kkousour, @GurpreetSinghChahal, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Sep 11, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22865/console Started: 2017/09/11 18:04

@cmsbuild
Copy link
Contributor

+1
Tested at: 12bfd6f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22865/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dfc38ed
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22865/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22865/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22865/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2563849
  • DQMHistoTests: Total failures: 216
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2563447
  • DQMHistoTests: Total skipped: 186
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

fabozzi
fabozzi reviewed Sep 11, 2017
View reviewed changes
Configuration/PyReleaseValidation/python/MatrixInjector.py Outdated
@@ -211,6 +211,7 @@ def prepare(self,mReader, directories, mode='init'):
wmsplit['HLTDR2_50ns']=1
wmsplit['HLTDR2_25ns']=1
wmsplit['HLTDR2_2016']=1
wmplit['HLTDR2_2017']=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prebello
please correct the typo in this line: wmplit -> wmsplit

@cmsbuild
Copy link
Contributor

Pull request #20461 was updated. @cmsbuild, @kkousour, @GurpreetSinghChahal, @kpedro88, @fabozzi can you please check and sign again.

@fabozzi
Copy link
Contributor

fabozzi commented Sep 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22891/console Started: 2017/09/12 12:06

@cmsbuild
Copy link
Contributor

+1
Tested at: f006a1e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22891/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
69441fc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22891/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22891/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Sep 12, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20461/22891/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 191
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642060
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@fabozzi fabozzi mentioned this pull request Sep 12, 2017
Merged
@fabozzi
Copy link
Contributor

fabozzi commented Sep 14, 2017

@kpedro88 @davidlange6
just a reminder for this to be signed off and merged for next release
Thanks!

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild added a commit that referenced this pull request Sep 15, 2017
@cmsbuild
Merge pull request #20478 from prebello/from-CMSSW_9_3_X_2017-09-12-1100
54b84bd 
[backport of 94X PR##20461] update in relvals
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b5157d4 into cms-sw:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabozzi fabozzi fabozzi left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prebello @cmsbuild @fabozzi @kpedro88 @davidlange6