New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[93X] Fix geometry centering tool. #20500
[93X] Fix geometry centering tool. #20500
Conversation
This way one avoids that the warning "hides" other output which was previously printed on the same line.
A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_3_X. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #20499
The previous sign-flip in the geometry comparison tool broke the geometry centering tool.
While fixing this I found with the help of @cschomak that one sign flip too much introduced previously.