HeavyFlavor Validation update #20520
Conversation
Internally used filter level assignment relied on the name of the modules, which can be ambiguous. Added an additional check on the type of the module to be a bit more stable and to prevent from multiple modules on the same level. The newly introduced function yields the same levels as the previous definition in dqmBeginRun, without having multiple modules on the same level. Removed some trailing whitespace as well.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20520/705 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20520/705/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @tmadlener (Thomas Madlener) for master. It involves the following packages: HLTriggerOffline/HeavyFlavor @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuil, please test |
|
@tmadlener first of all, thanks ! |
|
@mtosi which directory are you referring to? The output directory of the plots or the package directory inside cmssw? The first one is no problem. Only one parameter in the config file has to be changed for that and according to my quick check there is currently no conflicting BPH folder in the output directory. The second one is a bit more work, but should be possible as well. However, I would have to check how many files would have to be changed and some of them probably would also need to be renamed. You can probably judge better than me how much additional work would be involved in that (just the renaming, etc. part). |
|
sorry the confusion
I mean
baseFolderPath = 'HLT/HeavyFlavor/HLT/'
-->
baseFolderPath = 'HLT/BPH/'
thanks
mia
…On Mon, Sep 18, 2017 at 2:01 PM, Thomas Madlener ***@***.***> wrote:
@mtosi <https://github.com/mtosi> which directory are you referring to?
The output directory of the plots or the package directory inside cmssw?
The first one is no problem. Only one parameter in the config file has to
be changed for that and according to my quick check there is currently no
conflicting BPH folder in the output directory.
The second one is a bit more work, but should be possible as well.
However, I would have to check how many files would have to be changed and
some of them probably would also need to be renamed. You can probably judge
better than me how much additional work would be involved in that (just the
renaming, etc. part).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20520 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt581gbJaDWDHmZqJYGTQTupcjOr1Nhks5sjluTgaJpZM4PYHWP>
.
|
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #20520 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
please test
On 25 Sep 2017, at 09:49, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
Pull request #20520<#20520> was updated. @kmaeshima<https://github.com/kmaeshima>, @cmsbuild<https://github.com/cmsbuild>, @vanbesien<https://github.com/vanbesien>, @vazzolini<https://github.com/vazzolini>, @dmitrijus<https://github.com/dmitrijus> can you please check and sign again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20520 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw6anZd2yBQGNlBZFMpsuizpznyRWks5sl6FKgaJpZM4PYHWP>.
|
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Necessary updates to have meaningful/filled validation plots again for the HeavyFlavor validation package (used by BPH for RelVal):