New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 2 amendment: Simulation Clang tidy code-checks-all and Clang Warnings Removed #20527
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
hold |
Pull request has been put on hold by @ianna |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
hi @civanch - this is ready to go, no? |
@davidlange6 , the PR is OK but just recently you merge exotica fix PR. There is , at least, one common file in which modifications are orthogonal, but I am not sure if re-base of this PR on top of the new IB is needed or not. |
unhold |
@civanch - there are no conflicts, so it should be ready to go IMHO |
merge |
+1 |
@civanch - FYI, just to make sure that modifications by hand do not introduce any changes. When #20525 is merged, I'll rebase this one if needed.