Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 2 amendment: Simulation Clang tidy code-checks-all and Clang Warnings Removed #20527

Merged
merged 4 commits into from Sep 16, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 15, 2017

@civanch - FYI, just to make sure that modifications by hand do not introduce any changes. When #20525 is merged, I'll rebase this one if needed.

@ianna
Copy link
Contributor Author

ianna commented Sep 15, 2017

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20527/713

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22993/console Started: 2017/09/15 10:00

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/CherenkovAnalysis
SimG4CMS/EcalTestBeam
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam
SimG4CMS/Muon
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/Application
SimG4Core/CheckSecondary
SimG4Core/CountProcesses
SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/Generators
SimG4Core/Geometry
SimG4Core/GeometryProducer
SimG4Core/HelpfulWatchers
SimG4Core/KillSecondaries
SimG4Core/MagneticField
SimG4Core/Notification
SimG4Core/Physics
SimG4Core/PhysicsLists
SimG4Core/PrintGeomInfo
SimG4Core/PrintTrackNumber
SimG4Core/SaveSimTrackAction
SimG4Core/SensitiveDetector
SimG4Core/TrackingVerbose
SimG4Core/Watcher
SimRomanPot/SimFP420

@cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @namapane, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Sep 15, 2017

@ianna , the difference with #20525 is in one line only with the fix, which is obvious, so I would keep #20525 only for memory and try to merge only this one.

@ianna
Copy link
Contributor Author

ianna commented Sep 15, 2017

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @ianna
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20527/22993/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646476
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

hi @civanch - this is ready to go, no?

@civanch
Copy link
Contributor

civanch commented Sep 15, 2017

@davidlange6 , the PR is OK but just recently you merge exotica fix PR. There is , at least, one common file in which modifications are orthogonal, but I am not sure if re-base of this PR on top of the new IB is needed or not.

@ianna
Copy link
Contributor Author

ianna commented Sep 16, 2017

unhold

@cmsbuild cmsbuild removed the hold label Sep 16, 2017
@ianna
Copy link
Contributor Author

ianna commented Sep 16, 2017

@civanch - there are no conflicts, so it should be ready to go IMHO

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 390ffe7 into cms-sw:master Sep 16, 2017
@civanch
Copy link
Contributor

civanch commented Sep 16, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants