Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 8: Simulation Clang tidy code-checks-all #20534

Merged
merged 10 commits into from Sep 18, 2017
Merged

Step 8: Simulation Clang tidy code-checks-all #20534

merged 10 commits into from Sep 18, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 15, 2017

Step 8. SimDataFormats

@civanch - FYI

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Sep 15, 2017
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Sep 15, 2017

Note, the number of files in total is 716 ( there were 706 in #20511) due to SimRomanPot package added in Step 1.

@ianna
Copy link
Contributor Author

ianna commented Sep 15, 2017

please test

@ianna
Copy link
Contributor Author

ianna commented Sep 15, 2017

@davidlange6 - FYI, this PR is more complete then #20511

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20534/724

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23004/console Started: 2017/09/15 12:13

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimCalorimetry/CaloSimAlgos
SimCalorimetry/CastorSim
SimCalorimetry/CastorTechTrigProducer
SimCalorimetry/EcalEBTrigPrimAlgos
SimCalorimetry/EcalEBTrigPrimProducers
SimCalorimetry/EcalElectronicsEmulation
SimCalorimetry/EcalSelectiveReadoutAlgos
SimCalorimetry/EcalSelectiveReadoutProducers
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimCalorimetry/EcalTestBeam
SimCalorimetry/EcalTestBeamAlgos
SimCalorimetry/EcalTrigPrimAlgos
SimCalorimetry/EcalTrigPrimProducers
SimCalorimetry/EcalZeroSuppressionProducers
SimCalorimetry/HGCalSimProducers
SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalTestBeam
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers
SimCalorimetry/HcalZeroSuppressionProducers
SimDataFormats/Associations
SimDataFormats/CaloHit
SimDataFormats/GeneratorProducts
SimDataFormats/ValidationFormats
SimFastTiming/FastTimingCommon
SimG4CMS/Calo
SimG4CMS/CherenkovAnalysis
SimG4CMS/EcalTestBeam
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam
SimG4CMS/Muon
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/Application
SimG4Core/CheckSecondary
SimG4Core/CountProcesses
SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/Generators
SimG4Core/Geometry
SimG4Core/GeometryProducer
SimG4Core/HelpfulWatchers
SimG4Core/KillSecondaries
SimG4Core/MagneticField
SimG4Core/Notification
SimG4Core/Physics
SimG4Core/PhysicsLists
SimG4Core/PrintGeomInfo
SimG4Core/PrintTrackNumber
SimG4Core/SaveSimTrackAction
SimG4Core/SensitiveDetector
SimG4Core/TrackingVerbose
SimG4Core/Watcher
SimGeneral/CaloAnalysis
SimGeneral/DataMixingModule
SimGeneral/GFlash
SimGeneral/HepPDTESSource
SimGeneral/HepPDTRecord
SimGeneral/MixingModule
SimGeneral/NoiseGenerators
SimGeneral/PileupInformation
SimGeneral/TrackingAnalysis
SimMuon/CSCDigitizer
SimMuon/DTDigitizer
SimMuon/GEMDigitizer
SimMuon/MCTruth
SimMuon/Neutron
SimMuon/RPCDigitizer
SimRomanPot/SimFP420
SimTracker/Common
SimTracker/SiPhase2Digitizer
SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer
SimTracker/TrackAssociation
SimTracker/TrackAssociatorProducers
SimTracker/TrackHistory
SimTracker/TrackTriggerAssociation
SimTracker/TrackerFilters
SimTracker/TrackerHitAssociation
SimTracker/TrackerMaterialAnalysis
SimTracker/VertexAssociation

@thuer, @efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @govoni can you please review it and eventually sign? Thanks.
@abbiendi, @kpedro88, @argiro, @pfs, @threus, @mmusich, @LBeck, @sethzenz, @JyothsnaKomaragiri, @makortel, @acaudron, @sdevissc, @jlagram, @jhgoh, @lgray, @cnuttens, @prolay, @HuguesBrun, @ferencek, @trocino, @vandreev11, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @ptcox, @wmtford, @ebrondol, @dgulhan, @namapane, @battibass, @gbenelli, @calderona, @mverzett, @dkotlins, @imarches, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 969c9db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23004/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9f20abe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23004/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23004/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23004/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 207
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646473
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Sep 18, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23028/console Started: 2017/09/18 09:57

@cmsbuild
Copy link
Contributor

+1
Tested at: 969c9db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23028/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
390ffe7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23028/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23028/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20534/23028/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2648186
  • DQMHistoTests: Total failures: 213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2647784
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ea7d185 into cms-sw:master Sep 18, 2017
@smuzaffar smuzaffar mentioned this pull request Sep 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available generators-pending l1-pending orp-pending pending-signatures simulation-pending tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianna @cmsbuild @davidlange6