New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename 2017MCTunes folder to MCTunes2017 to avoid import * problems #20572
Conversation
please test |
@perrozzi, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @perrozzi for master. It involves the following packages: Configuration/Generator @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@smuzaffar would it make sense to add this (i.e. no folders and filenames starting with numerical values) in the code-checks? |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks |
restore usual convention for PSet naming as old tune https://github.com/cms-sw/cmssw/blob/CMSSW_9_3_0/Configuration/Generator/python/Pythia8CUEP8M1Settings_cfi.py |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
No description provided.