MiniAOD: PackedCandidate::setP4 preserve track kinematic #20574
Conversation
|
The code-checks are being triggered in jenkins. |
arizzi
changed the title
|
+code-checks |
|
A new Pull Request was created by @arizzi for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@arizzi : is there any sample in which one can see the effect of this fix? Does it also apply to standard workflows or just to some analysis code? |
|
only analysis code, no effect expected but the just added unit test would
fail without the fix
…On Tue, Sep 26, 2017 at 10:01 AM, perrotta ***@***.***> wrote:
@arizzi <https://github.com/arizzi> : is there any sample in which one
can see the effect of this fix? Does it also apply to standard workflows or
just to some analysis code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20574 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEyilkehjyXGJXfgcCddwRv1mLhWN8_Jks5smK9UgaJpZM4PcKke>
.
|
|
+1
|
|
merge |
update the delta pt,eta,phi when calling setP4 and setPz so that track momentum is unchanged as discussed in XPOG meeting on sept 4th.
Seems to do the right thing (similar unit test added)
root [0] pat::PackedCandidate a;
root [1] a.eta()
(double) 0.000000
root [2] a.etaAtVtx()
(float) 0.00000f
root [3] a.pt()
(double) 0.000000
root [7] a.ptTrk()
(double) 0.000000
root [8] a.setP4(reco::Candidate::PolarLorentzVector(10,2,3,5))
root [9] a.ptTrk()
(double) 0.000000
root [10] a.pt()
(double) 10.000000
root [11] a.eta()
(double) 1.999939
root [12] a.etaAtVtx()
(float) -0.00006f
root [13] a.setPz(10)
root [14] a.eta()
(double) 0.881314
root [15] a.etaAtVtx()
(float) -0.00003f