New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX in GBL reference trajectories: add missing initialisations #20581
FIX in GBL reference trajectories: add missing initialisations #20581
Conversation
Adds missing matrix initialisations to the EIGEN matrices. This was not needed in previous implementation of GBL based on ROOT TMatrix (ROOT presets matrices to 0., EIGEN not). Fix provided by @ckleinw
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_9_3_X. It involves the following packages: Alignment/ReferenceTrajectories @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
type bugfix |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
Backport of #20262
Adds missing matrix initialisations to the EIGEN matrices.
This was not needed in previous implementation of GBL based on ROOT TMatrix
(ROOT presets matrices to 0., EIGEN not).
Fix provided by @ckleinw