Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add muon->innerTrack monitoring in DQM #20627

Merged
merged 1 commit into from Sep 26, 2017

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Sep 22, 2017

it is the 94x version of PR #19622

as requested by tracking POG (@VinInn @rovere @makortel )
this PR does

  • fix the client (some hit efficiency plots were missing)
  • add the monitoring of muon->innerTrack
    new plots are under Muons/Tracking/innerTrack
    (as suggested/requested/proposed by @VinInn )
    a pT > 10 GeV cut is applied to muons

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Sep 22, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20627/912

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23171/console Started: 2017/09/22 14:32

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQMOffline/Muon

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@barvic, @hdelanno, @battibass, @makortel, @threus, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @fioriNTU, @calderona, @ptcox, @idebruyn, @ebrondol, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20627/23171/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2661038
  • DQMHistoTests: Total failures: 212
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2660637
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 15 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fcc3ee3 into cms-sw:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants