fix on mean s/n calculation

[jandrea]

Fix a bug in the mean S/N calculation for the ControlView plots in the SiStrip directory. For 94X release.

[cmsbuild]

@jandrea, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20663/982

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20663/982/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20663/982/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[jandrea]

ok. I ran "scram build code-checks", then did git add and git commit.

[davidlange6]

Then do git push so that the update goes to github On 27 Sep 2017, at 07:20, jandrea <notifications@github.com<mailto:notifications@github.com>> wrote: ok. I ran "scram build code-checks", then did git add and git commit. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#20663 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzKHYLSFCcaO790q0izWBjgxyvPsks5smiE0gaJpZM4Plg8U>.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20663/985

[cmsbuild]

A new Pull Request was created by @jandrea for master.

It involves the following packages:

DQM/SiStripMonitorTrack

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[jandrea]

@davidlange6 Yes sorry. It should be done now.

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23351/console Started: 2017/10/02 10:57

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 86f7f78
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20663/23351/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6fa527f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20663/23351/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20663/23351/git-merge-result

[cmsbuild]

Comparison job queued.

[davidlange6]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20663/23351/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2760941
• DQMHistoTests: Total failures: 358
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760396
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files