[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking #20675

tstreble · 2017-09-27T16:34:58Z

Adds a new tracking region producer for HLT Tracking.
Provides same functionality than existing CandidateSeededTrackingRegion and PointSeededTrackingRegion producers + introduces new functionality with combination of candidate+point-seeded regions.
Once integrated and HLT configuration is updated, possible to make CandidateSeededTrackingRegion and PointSeededTrackingRegion producers deprecated.

This is the 92X back port of #20672

cmsbuild · 2017-09-27T16:35:16Z

A new Pull Request was created by @tstreble for CMSSW_9_2_X.

It involves the following packages:

RecoTauTag/HLTProducers
RecoTracker/TkTrackingRegions

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2017-09-28T04:37:38Z

please test

cmsbuild · 2017-09-28T04:40:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23285/console Started: 2017/09/28 06:40

cmsbuild · 2017-09-28T06:19:02Z

-1

Tested at: 5e78c2d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0393326
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23285/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23285/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23285/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v31.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:00:57 2017-date Thu Sep 28 07:54:44 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_MC.root --fileout file:RelVal_Raw_2e34v31_MC_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:00:57 2017-date Thu Sep 28 07:54:44 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v30.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:00:34 2017-date Thu Sep 28 07:54:46 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v30,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v30 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v30_MC.root --fileout file:RelVal_Raw_2e34v30_MC_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:00:34 2017-date Thu Sep 28 07:54:46 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 07:59:01 2017-date Thu Sep 28 07:54:56 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 28 07:59:01 2017-date Thu Sep 28 07:54:56 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:01:17 2017-date Thu Sep 28 07:55:07 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:01:17 2017-date Thu Sep 28 07:55:07 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v31.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:04:18 2017-date Thu Sep 28 08:00:35 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_DATA.root --fileout file:RelVal_Raw_2e34v31_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:04:18 2017-date Thu Sep 28 08:00:35 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v30.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:04:25 2017-date Thu Sep 28 08:00:48 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v30,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v30 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v30_DATA.root --fileout file:RelVal_Raw_2e34v30_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:04:25 2017-date Thu Sep 28 08:00:48 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:09:07 2017-date Thu Sep 28 08:01:48 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_MC.root --fileout file:RelVal_Raw_2e34v22_MC_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:09:07 2017-date Thu Sep 28 08:01:48 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:08:36 2017-date Thu Sep 28 08:04:27 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:08:36 2017-date Thu Sep 28 08:04:27 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:10:17 2017-date Thu Sep 28 08:04:32 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:10:17 2017-date Thu Sep 28 08:04:32 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 28 08:10:38 2017-date Thu Sep 28 08:08:44 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_DATA.root --fileout file:RelVal_Raw_2e34v22_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 28 08:10:38 2017-date Thu Sep 28 08:08:44 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0393326
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23285/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23285/git-merge-result

cmsbuild · 2017-09-28T06:19:04Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Martin-Grunewald · 2017-09-28T06:34:24Z

Looks like the backport PR is missing a file from the 94 PR.

cmsbuild · 2017-09-28T07:02:32Z

Pull request #20675 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

Martin-Grunewald · 2017-09-28T08:33:26Z

please test

cmsbuild · 2017-09-28T08:33:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23288/console Started: 2017/09/28 10:34

cmsbuild · 2017-10-05T10:47:25Z

Pull request #20675 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

perrotta · 2017-10-05T11:35:54Z

please test

cmsbuild · 2017-10-05T11:36:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23462/console Started: 2017/10/05 14:50

cmsbuild · 2017-10-05T15:07:48Z

+1
Tested at: 18dcad0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23462/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f5667ff
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23462/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23462/git-merge-result

cmsbuild · 2017-10-05T15:07:51Z

Comparison job queued.

cmsbuild · 2017-10-05T17:13:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20675/23462/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1967239
DQMHistoTests: Total failures: 44269
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1922798
DQMHistoTests: Total skipped: 172
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 9 edm output root files, 23 DQM output files

perrotta · 2017-10-05T20:39:45Z

+1

Identical to New Candidate+Point seeded tracking region producer for Tau HLT tracking #20672 in the master

Martin-Grunewald · 2017-10-06T11:52:53Z

+1

cmsbuild · 2017-10-06T11:53:15Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-10-09T07:47:24Z

+1

Created cand+point-seed trk region producer

5e78c2d

cmsbuild added this to the CMSSW_9_2_X milestone Sep 27, 2017

cmsbuild added comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 27, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Sep 28, 2017

Fixed missing SealModule

70fffe0

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Sep 28, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2017

Made etaPoints and phiPoints local

18dcad0

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 5, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 5, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 5, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Oct 6, 2017

cmsbuild added orp-approved and removed orp-pending labels Oct 9, 2017

cmsbuild merged commit 067a76d into cms-sw:CMSSW_9_2_X Oct 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking #20675

[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking #20675

tstreble commented Sep 27, 2017

cmsbuild commented Sep 27, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Oct 5, 2017

perrotta commented Oct 5, 2017

cmsbuild commented Oct 5, 2017 •

edited

cmsbuild commented Oct 5, 2017

cmsbuild commented Oct 5, 2017

cmsbuild commented Oct 5, 2017

perrotta commented Oct 5, 2017

Martin-Grunewald commented Oct 6, 2017

cmsbuild commented Oct 6, 2017

davidlange6 commented Oct 9, 2017

[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking #20675

[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking #20675

Conversation

tstreble commented Sep 27, 2017

cmsbuild commented Sep 27, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 • edited

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

Martin-Grunewald commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 • edited

cmsbuild commented Oct 5, 2017

perrotta commented Oct 5, 2017

cmsbuild commented Oct 5, 2017 • edited

cmsbuild commented Oct 5, 2017

cmsbuild commented Oct 5, 2017

cmsbuild commented Oct 5, 2017

perrotta commented Oct 5, 2017

Martin-Grunewald commented Oct 6, 2017

cmsbuild commented Oct 6, 2017

davidlange6 commented Oct 9, 2017

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Oct 5, 2017 •

edited