Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[94X] Make muon HLT (L3/TkMu) work in phaseII scenarios #20723

Merged
merged 3 commits into from Oct 9, 2017

Conversation

battibass
Copy link

This PR:

  • makes TSGForOI work in Phase2 (as done for offline the outside-in muon iteration in PR 18553)
  • fixes a small initilaization issue in MaskedMeasurementTrackerEventProducer

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20723/1100

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20723/1100/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20723/1100/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@slava77
Copy link
Contributor

slava77 commented Oct 2, 2017

@battibass
passing code-checks is required
please apply the patch

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20723/1102

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

RecoMuon/TrackerSeedGenerator
RecoTracker/MeasurementDet

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @bellan, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @echapon, @calderona, @HuguesBrun, @mschrode, @rovere, @gpetruc, @ebrondol, @trocino, @dgulhan, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Oct 3, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23384/console Started: 2017/10/03 09:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20723/23384/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761357
  • DQMHistoTests: Total failures: 240
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2760930
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 7, 2017

+1

for #20723 4832fd5

  • updates to make TSGForOI used in HLT to work in phase2
  • jenkins tests pass and comparisons show no differences (phase-2 workflows do not include HLT algorithms, only a fake table)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor

slava77 commented Oct 7, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f0f0b31 into cms-sw:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants