New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Hgg low-mass HLT path added to DQM #20731
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @lfinco (Linda Finco) for master. It involves the following packages: DQMOffline/Trigger @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -201,6 +201,7 @@ | |||
"HLT_Diphoton30PV_18PV_R9Id_AND_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v", | |||
"HLT_Diphoton30EB_18EB_R9Id_OR_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v", | |||
"HLT_Diphoton30EB_18EB_R9Id_OR_IsoCaloId_AND_HE_R9Id_PixelVeto_Mass55_v", | |||
"HLT_Diphoton30_18_PVrealAND_R9Id_AND_IsoCaloId_AND_HE_R9Id_PixelVeto_Mass55_v", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need v*
did you test this PR ?
can you point to the plots, please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about
HLT_Diphoton30_18_PVrealAND_R9Id_AND_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v* ?
@cmbuild, please test |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks |
Yes, now it should be in. |
Pull request #20731 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
@lfinco
can we proceed w/ the integration test ?
…On Fri, Oct 6, 2017 at 4:19 PM, cmsbuild ***@***.***> wrote:
The code-checks are being triggered in jenkins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20731 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58_3ypiszrd1vJGX195LOLTOPM9pdks5spjbWgaJpZM4PsXMa>
.
|
yes, thanks |
@cmsbuild, please test
…On Fri, Oct 6, 2017 at 4:25 PM, Linda Finco ***@***.***> wrote:
Yes, now it should be in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20731 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt580_DgaZtwXVcVk6RnmkMTLC-9Czwks5spjhcgaJpZM4PsXMa>
.
|
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@dmitrijus can we proceed ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Added a new HLT path (for the Hgg low-mass analysis) to the existing DQM code for diphoton triggers.