Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Hgg low-mass HLT path added to DQM #20731

Merged
merged 7 commits into from Oct 11, 2017
Merged

Conversation

lfinco
Copy link
Contributor

@lfinco lfinco commented Oct 3, 2017

Added a new HLT path (for the Hgg low-mass analysis) to the existing DQM code for diphoton triggers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20731/1112

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

A new Pull Request was created by @lfinco (Linda Finco) for master.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Higgs

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@@ -201,6 +201,7 @@
"HLT_Diphoton30PV_18PV_R9Id_AND_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v",
"HLT_Diphoton30EB_18EB_R9Id_OR_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v",
"HLT_Diphoton30EB_18EB_R9Id_OR_IsoCaloId_AND_HE_R9Id_PixelVeto_Mass55_v",
"HLT_Diphoton30_18_PVrealAND_R9Id_AND_IsoCaloId_AND_HE_R9Id_PixelVeto_Mass55_v",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need v*

did you test this PR ?
can you point to the plots, please ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about
HLT_Diphoton30_18_PVrealAND_R9Id_AND_IsoCaloId_AND_HE_R9Id_NoPixelVeto_Mass55_v* ?

@mtosi
Copy link
Contributor

mtosi commented Oct 3, 2017

@cmbuild, please test

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23427/console Started: 2017/10/04 10:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20731/23427/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761357
  • DQMHistoTests: Total failures: 257
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2760906
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20731/1199

@lfinco
Copy link
Contributor Author

lfinco commented Oct 6, 2017

Yes, now it should be in.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Pull request #20731 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Oct 6, 2017 via email

@lfinco
Copy link
Contributor Author

lfinco commented Oct 6, 2017

yes, thanks

@mtosi
Copy link
Contributor

mtosi commented Oct 6, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23502/console Started: 2017/10/06 16:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20731/23502/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761427
  • DQMHistoTests: Total failures: 257
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 2760971
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@mtosi
Copy link
Contributor

mtosi commented Oct 10, 2017

@dmitrijus can we proceed ?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8f333ea into cms-sw:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants