clang-tidy check for FWCore #20750
clang-tidy check for FWCore #20750
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/Common @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -27,14 +27,14 @@ class BranchToClass : private TVirtualBranchBrowsable | |||
|
|
|||
| private: | |||
| ///NOTE: do not call this, it is only here because ROOT demands it | |||
| BranchToClass(); | |||
| BranchToClass() = delete; | |||
There was a problem hiding this comment.
From the comment, it seems the constructor is needed.
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
the comment is from 2006... - can you reconstruct if this was fixed in root6? [things do compile/run/give the right answers]
… On Oct 5, 2017, at 3:48 PM, Chris Jones ***@***.***> wrote:
@Dr15Jones commented on this pull request.
In FWCore/FWLite/src/branchToClass.cc:
> @@ -27,14 +27,14 @@ class BranchToClass : private TVirtualBranchBrowsable
private:
///NOTE: do not call this, it is only here because ROOT demands it
- BranchToClass();
+ BranchToClass() = delete;
From the comment, it seems the constructor is needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
+1 |
|
The BranchToClass class is in an anonymous namespace within a .cc file. It can never actually be seen by ROOT. So false alarm. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR to apply clang-tidy checks to all FWCore files except those that are a part of open pull requests (as of an hour ago) and files in test directories