Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy checks for HiggsAnalysis #20810

Merged
merged 2 commits into from Oct 8, 2017

Conversation

davidlange6
Copy link
Contributor

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this quickly to avoid conflicts to the extent possible]

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20810/1253

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

HiggsAnalysis/HiggsToGammaGamma
HiggsAnalysis/Skimming
SUSYBSMAnalysis/HSCP

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23561/console Started: 2017/10/07 21:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20810/23561/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761427
  • DQMHistoTests: Total failures: 233
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2761007
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 93b1722 into cms-sw:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants