Clang-tidy checks for Fireworks #20861
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Fireworks/Calo @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 Thank You! |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
|
merge |
PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this quickly to avoid conflicts to the extent possible]