New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fillDescriptions to MeasurementTrackerEventProducer #20891
Conversation
Faster than map (obviously slower than the vector), and takes less (not much though) memory than map or vector (ok, depends really how many Fed25-affected modules there are, I tested run 300811 that is supposed to have many of them).
The code-checks are being triggered in jenkins. |
Addresses issue #20703. |
+code-checks |
@cmsbuild, please test |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoTracker/MeasurementDet @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: d054070 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
1000.0 step3 failure is not from this PR |
@cmsbuild please test |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR addresses the "POG code review comments" of #20151, main changes:
fillDescriptions
toMeasurementTrackerEventProducer
vector<unique_ptr<...>>
withunordered_map
vector
,map
, andunordered_map
, andunordered_map
was faster thanmap
and took less memory than eithermap
orvector
(although numbers are totally insignificant wrt. tracking total, or even a single iteration)Tested in CMSSW_9_4_X_2017-10-03-0000, no changes expected.
@VinInn