Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fillDescriptions to MeasurementTrackerEventProducer #20891

Merged
merged 3 commits into from Oct 13, 2017

Conversation

makortel
Copy link
Contributor

This PR addresses the "POG code review comments" of #20151, main changes:

  • add fillDescriptions to MeasurementTrackerEventProducer
  • replace vector<unique_ptr<...>> with unordered_map
    • I tested run 300811 comparing vector, map, and unordered_map, and unordered_map was faster than map and took less memory than either map or vector (although numbers are totally insignificant wrt. tracking total, or even a single iteration)
  • some cleanup

Tested in CMSSW_9_4_X_2017-10-03-0000, no changes expected.

@VinInn

Faster than map (obviously slower than the vector), and takes less
(not much though) memory than map or vector (ok, depends really how
many Fed25-affected modules there are, I tested run 300811 that is
supposed to have many of them).
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@makortel
Copy link
Contributor Author

Addresses issue #20703.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20891/1372

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoTracker/MeasurementDet

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23671/console Started: 2017/10/11 12:23

@cmsbuild
Copy link
Contributor

-1

Tested at: d054070

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23671/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23671/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23671/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23671/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23671/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@makortel
Copy link
Contributor Author

1000.0 step3 failure is not from this PR

@slava77
Copy link
Contributor

slava77 commented Oct 11, 2017

@cmsbuild please test

@perrotta
Copy link
Contributor

please test
(the latest IB, CMSSW_9_4_X_2017-10-11-2300, should finally contain the fix for the issue in the RelVal wf 1000)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23706/console Started: 2017/10/12 09:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20891/23706/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766774
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 12, 2017

+1

for #20891 d054070

  • somewhat technical updates, in line with the PR description
  • jenkins tests pass and comparisons show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eedbcd1 into cms-sw:master Oct 13, 2017
@makortel makortel deleted the pr20151_pog_updates branch February 12, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants