Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ecorr computations in phase-2 because they are too slow for high-PU #20949

Merged
merged 1 commit into from Oct 19, 2017

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Oct 18, 2017

#20558 (comment)

in PU 200 the total of 4 nb[12] modules is more than full tracking time.
This can be re-enabled once adjusted to acceptable time or optimized in some other way.

@rappoccio
a prompt alternative for this is welcome

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Oct 18, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20949/1507

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23829/console Started: 2017/10/18 08:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20949/23829/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2793415
  • DQMHistoTests: Total failures: 115
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793129
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

+1

@slava77
Copy link
Contributor Author

slava77 commented Oct 18, 2017

+1

for #20949 157c5b5

  • disable for high-PU/high occupancy workflows until a faster working version is available
  • jenkins tests pass
  • reduction of time was tested earlier for a similar case with pp_on_XeXe_2017

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit bc08d34 into cms-sw:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants