Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add originalXWGTUP() to LHEEvent and LHEEventProduct #2097

Merged
merged 1 commit into from Feb 3, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 21, 2014

Add some book-keeping information to LHEEvent and LHEEventProduct so that reweighting is less cumbersome.

In the MG5 scheme, users can now do raw_ME_ratio[i] = eventInfo->weights()[i]/eventInfo->originalXWGTUP();

To get the raw matrix element ratio.

I have checked that this is stored correctly by writing out the LHE file that was read in.
The XWGTUP parameters matched exactly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_1_X.

add originalXWGTUP() to LHEEvent and LHEEventProduct

It involves the following packages:

GeneratorInterface/LHEInterface
SimDataFormats/GeneratorProducts

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/read.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/models.F 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/crmc-aaa.f 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/epos-bas.f 
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc: In member function 'virtual void MCatNLOSource::produce(edm::Event&)':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:189:68: error: no matching function for call to 'LHEEventProduct::LHEEventProduct(lhef::HEPEUP&)'
   std::auto_ptr lhEvent(new LHEEventProduct(hepeup));
                                                                    ^
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:189:68: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/LHEInterface/interface/LHEEvent.h:19:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:18:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2097/19/summary.html

@lgray
Copy link
Contributor Author

lgray commented Jan 21, 2014

Will fix it in just a bit and update related PRs.

@lgray
Copy link
Contributor Author

lgray commented Jan 21, 2014

Fixed and changes propagated to all flavors of the commits.

@cmsbuild
Copy link
Contributor

Pull request #2097 was updated. @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

@vciulli
Copy link
Contributor

vciulli commented Feb 3, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 3, 2014
add originalXWGTUP() to LHEEvent and LHEEventProduct
@ktf ktf merged commit 88d89de into cms-sw:CMSSW_7_1_X Feb 3, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants