New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add originalXWGTUP() to LHEEvent and LHEEventProduct #2097
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_1_X. add originalXWGTUP() to LHEEvent and LHEEventProduct It involves the following packages: GeneratorInterface/LHEInterface @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks. |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/read.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/models.F >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/crmc-aaa.f >> Compiling /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/ReggeGribovPartonMCInterface/src/epos-bas.f /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc: In member function 'virtual void MCatNLOSource::produce(edm::Event&)': /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:189:68: error: no matching function for call to 'LHEEventProduct::LHEEventProduct(lhef::HEPEUP&)' std::auto_ptr lhEvent(new LHEEventProduct(hepeup)); ^ /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:189:68: note: candidates are: In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/LHEInterface/interface/LHEEvent.h:19:0, from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-7_1_X@4/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_1_X_2014-01-21-0200/src/GeneratorInterface/MCatNLOInterface/plugins/MCatNLOSource.cc:18: you can see the results of the tests here: |
Will fix it in just a bit and update related PRs. |
…ing is less cumbersome
Fixed and changes propagated to all flavors of the commits. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @ktf can you please take care of it? |
add originalXWGTUP() to LHEEvent and LHEEventProduct
upgrade lhapdf to 6.1.6
Add some book-keeping information to LHEEvent and LHEEventProduct so that reweighting is less cumbersome.
In the MG5 scheme, users can now do raw_ME_ratio[i] = eventInfo->weights()[i]/eventInfo->originalXWGTUP();
To get the raw matrix element ratio.
I have checked that this is stored correctly by writing out the LHE file that was read in.
The XWGTUP parameters matched exactly.