Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix binning in muon->innerTrack DQM #20970

Merged
merged 5 commits into from Oct 26, 2017

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Oct 19, 2017

looking at the offline GUI,
I've just realized few histograms have larger binning than needed

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@VinInn @makortel
I'm going to prepare the backport for 92x

but,
I realized the hit efficiency plots have x-axis up to PU = 50
while doing this update in 94x I see that it is fixed here

shall I move to PU = 150 in 92x ?
or, in order to squeeze as much as possible the #bins, at least 60 ?

thanks

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@cmsbuild, please test

@VinInn
Copy link
Contributor

VinInn commented Oct 19, 2017

The problem with muon is that statistics is not very high: maybe we can go to 120 and use 60 bins?
this is how it looks in express for recent runs
image

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20970/1543

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23872/console Started: 2017/10/19 13:12

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQM/TrackingMonitor

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @fioriNTU, @idebruyn, @ebrondol, @threus this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20970/1545

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Oct 19, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20970/1550

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23880/console Started: 2017/10/19 15:50

@cmsbuild
Copy link
Contributor

Pull request #20970 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20970/23880/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2795245
  • DQMHistoTests: Total failures: 114
  • DQMHistoTests: Total nulls: 1005
  • DQMHistoTests: Total successes: 2793955
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3759f24 into cms-sw:master Oct 26, 2017
cmsbuild added a commit that referenced this pull request Oct 27, 2017
fix binning in muon->innerTrack DQM [backport #20970]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants