Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stand-alone tracker rechits validation cfg, root macro #20985

Merged
merged 1 commit into from Oct 25, 2017

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Oct 20, 2017

Changes to test directories only. Add a cfg that produces a RelVal-format root file with RecHit validation histograms from strips, and from pixels whether phase0 or phase1. Add also a root macro to compare histograms across pairs of root files.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20985/1580

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford (Bill Ford) for master.

It involves the following packages:

SimTracker/TrackerHitAssociation
Validation/TrackerRecHits

@civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Oct 21, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23911/console Started: 2017/10/21 11:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20985/23911/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2795796
  • DQMHistoTests: Total failures: 115
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2795510
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor

civanch commented Oct 22, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 19a55fa into cms-sw:master Oct 25, 2017
@wmtford wmtford deleted the rechitsValidso branch October 27, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants