Add needed changes to L1 digi to raw for premixing #20991
Conversation
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Configuration/StandardSequences @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
This appears to have broken the IBs. Shouldn’t the toModify calls be moved to |
|
where (which workflows) do you see things getting worse?
… On Oct 23, 2017, at 2:17 PM, Chris Jones ***@***.***> wrote:
This appears to have broken the IBs. Shouldn’t the toModify calls be moved to
https://github.com/cms-sw/cmssw/blob/eb8d8e46378a9a48661ec4708c6e176af3e6e627/EventFilter/L1TRawToDigi/python/caloLayer1Raw_cfi.py
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
ok, 50ns premixing... i fixed all the 25 ns premixing ones so its an improvement.
… On Oct 23, 2017, at 2:22 PM, David Lange ***@***.***> wrote:
where (which workflows) do you see things getting worse?
> On Oct 23, 2017, at 2:17 PM, Chris Jones ***@***.***> wrote:
>
> This appears to have broken the IBs. Shouldn’t the toModify calls be moved to
> https://github.com/cms-sw/cmssw/blob/eb8d8e46378a9a48661ec4708c6e176af3e6e627/EventFilter/L1TRawToDigi/python/caloLayer1Raw_cfi.py
> ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Comparison is ready Comparison Summary:
|
fixes failing step2 workflows (maybe other problems later in the chain)