include firstRun and lastRun in the run range for TkAlAlllInOne tool

[hroskes]

Fixing an obvious stupid mistake. firstRun and lastRun should be included in the run range. Previously they were excluded.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21007/1624

[cmsbuild]

A new Pull Request was created by @hroskes (Heshy Roskes) for master.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23960/console Started: 2017/10/24 16:11

[ghellwig]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 802a933
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21007/23960/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2efa972
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21007/23960/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21007/23960/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21007/23960/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
10024.0 step 5
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2529372
• DQMHistoTests: Total failures: 72
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529133
• DQMHistoTests: Total skipped: 167
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[davidlange6]

hi @hroskes - please change the title to be a bit more descriptive of where the fix is. Thanks

[hroskes]

@davidlange6 Done (and for the backport too).

[davidlange6]

still pretty much meaningless:) [unless you happen to know its for the Alignment validation] - maybe you can add "used for TkAlAlllInOne tool"

…

On Oct 25, 2017, at 12:04 PM, Heshy Roskes ***@***.***> wrote: @davidlange6 Done (and for the backport too). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[hroskes]

@davidlange6 modified again

[davidlange6]

+1