Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for pileup jet ID computed from MiniAOD #21018

Merged
merged 1 commit into from Oct 27, 2017
Merged

Add unit test for pileup jet ID computed from MiniAOD #21018

merged 1 commit into from Oct 27, 2017

Conversation

ahinzmann
Copy link
Contributor

@ahinzmann ahinzmann commented Oct 25, 2017 •
edited

to avoid issues like #20740 in the future.

I tested that "scram b runtests" fails in CMSSW_9_3_0 with this commit.

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Oct 25, 2017
@ahinzmann ahinzmann mentioned this pull request Oct 25, 2017
Merged
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21018/1642

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23982/console Started: 2017/10/25 18:55

@cmsbuild
Copy link
Contributor

-1

Tested at: d36213f

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56e6674
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Wed Oct 25 20:18:55 2017-date Wed Oct 25 20:15:51 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02495/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-10-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Oct 25 20:18:55 2017-date Wed Oct 25 20:15:51 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 25 20:18:55 2017-date Wed Oct 25 20:15:51 2017 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02495/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-10-25-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Wed Oct 25 20:18:16 2017-date Wed Oct 25 20:15:54 2017 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Wed Oct 25 20:19:26 2017-date Wed Oct 25 20:15:56 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02495/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-10-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Oct 25 20:19:26 2017-date Wed Oct 25 20:15:56 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 25 20:19:26 2017-date Wed Oct 25 20:15:56 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56e6674
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23982/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
10024.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 112 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2689186
  • DQMHistoTests: Total failures: 260
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2688756
  • DQMHistoTests: Total skipped: 170
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23989/console Started: 2017/10/26 07:18

@cmsbuild
Copy link
Contributor

+1
Tested at: d36213f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23989/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56e6674
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23989/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23989/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21018/23989/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2815041
  • DQMHistoTests: Total failures: 115
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2814755
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_10_0_X Oct 26, 2017
@cmsbuild cmsbuild modified the milestones: CMSSW_10_0_X, CMSSW_9_4_X Oct 26, 2017
@slava77
Copy link
Contributor

slava77 commented Oct 26, 2017

+1

for #21018 d36213f

  • extend PhysicsTools/PatAlgos/test/patTuple_updateJets_fromMiniAOD_cfg.py to include a test of rerunning PU jet ID on slimmedJets
  • jenkins tests pass

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 40c0ef7 into cms-sw:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-approved pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ahinzmann @cmsbuild @perrotta @slava77 @davidlange6 @smuzaffar