Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datatier for intermediate EDM NANOAOD stuff #21028

Merged
merged 1 commit into from Nov 1, 2017

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Oct 26, 2017

This should solve the problem observed in production of nanoaod with intermediate edm step

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21028/1654

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23998/console Started: 2017/10/26 16:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21028/23998/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2815041
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2814761
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Oct 27, 2017

+1

@arizzi
Copy link
Contributor Author

arizzi commented Oct 27, 2017 via email

@fabozzi
Copy link
Contributor

fabozzi commented Oct 27, 2017

no, in pending status actually

@davidlange6
Copy link
Contributor

Hi @arizzi @fabozzi from your comments- are there pending issues for this pr?

@fabozzi
Copy link
Contributor

fabozzi commented Oct 31, 2017

I think we should integrate with a fix to set up properly the process string of NANOMERGE step, as we learned from the injection test

@arizzi
Copy link
Contributor Author

arizzi commented Oct 31, 2017 via email

@fabozzi
Copy link
Contributor

fabozzi commented Oct 31, 2017

@arizzi
The ProcessingString is the parameter of the workflow that is used in the output dataset name. The GT of the step is copied in the ProcessingString: we need to avoid this for the NANOMERGE step and copy instead the GT of the NANOEDM step

master...fabozzi:from-CMSSW_9_4_0_pre3_nanoedmtest

I can also make a separate PR for this change in MatrixInjector

@fabozzi
Copy link
Contributor

fabozzi commented Oct 31, 2017

OK, I have inserted the change to MatrixInjector in the "Relval updates for 94X" (PR #21091).
This PR can go ahead as it is for me.

@arizzi
Copy link
Contributor Author

arizzi commented Oct 31, 2017

thanks, I was trying to add it here but we had twice the same commits and from phone it was impossible

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2f95528 into cms-sw:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants