Run2-hcx162 Remove remaining geometry bugs for HCAL

[bsunanda]

Thought some of the changes were made in PR#20976 but the merged version does not contain the changes

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21033/1662

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23999/console Started: 2017/10/26 16:29

[cmsbuild]

+1
Tested at: ffffd63
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/23999/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56e6674
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/23999/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/23999/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/23999/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2815041
• DQMHistoTests: Total failures: 231
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2814639
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[bsunanda]

@ianna Please approve this

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21033/1678

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24015/console Started: 2017/10/27 19:48

[cmsbuild]

Pull request #21033 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

[cmsbuild]

+1
Tested at: e8ebefd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/24015/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
45a2438
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/24015/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/24015/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21033/24015/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2838442
• DQMHistoTests: Total failures: 117
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2838154
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge