New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGCal EGamma ID helpers and Phase-II MiniAOD 93x #21045
HGCal EGamma ID helpers and Phase-II MiniAOD 93x #21045
Conversation
Originally https://github.com/CMS-HGCAL/EgammaTools Moving into existing cmssw package to embed HGCal Egamma objects into phase 2 miniAOD production.
A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_9_3_X. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
assign upgrade |
please test |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
# so add companion collections for Phase-II MiniAOD production | ||
from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal | ||
from PhysicsTools.PatAlgos.slimming.addHGCalEgammaCollections import addHGCalEgammaCollections | ||
if phase2_hgcal.isChosen(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpedro88
I recall that you mentioned (in ORP?) that 93X updates to miniAOD will come without modifying the default miniAOD of 93X.
This PR changes the default.
Please clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slava77 though the use of eras can be improved (as commented in the master branch PR), this doesn't change the default 93X miniAOD.
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
+1
|
merge |
backport of #21037