Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal EGamma ID helpers and Phase-II MiniAOD 93x #21045

Merged
merged 20 commits into from Dec 5, 2017

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Oct 27, 2017

backport of #21037

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2017

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_9_3_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @TaiSakuma, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @acaudron, @lgray, @jdolen, @ferencek, @Sam-Harper, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

assign upgrade

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24013/console Started: 2017/10/27 19:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21045/24013/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2708283
  • DQMHistoTests: Total failures: 239
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2707857
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

# so add companion collections for Phase-II MiniAOD production
from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal
from PhysicsTools.PatAlgos.slimming.addHGCalEgammaCollections import addHGCalEgammaCollections
if phase2_hgcal.isChosen():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpedro88
I recall that you mentioned (in ORP?) that 93X updates to miniAOD will come without modifying the default miniAOD of 93X.
This PR changes the default.
Please clarify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 though the use of eras can be improved (as commented in the master branch PR), this doesn't change the default 93X miniAOD.

@cmsbuild
Copy link
Contributor

Pull request #21045 was updated. @perrotta, @cmsbuild, @monttj, @kpedro88, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Nov 28, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24735/console Started: 2017/11/28 22:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21045/24735/summary.html

There are some workflows for which there are errors in the baseline:
136.788 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2572974
  • DQMHistoTests: Total failures: 232
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2572563
  • DQMHistoTests: Total skipped: 179
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 103 log files, 8 edm output root files, 25 DQM output files

@kpedro88
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Nov 29, 2017

+1

for #21045 1b7ef0f

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fc4c4d0 into cms-sw:CMSSW_9_3_X Dec 5, 2017
@nsmith- nsmith- deleted the HGCalEgammaInMiniAOD_93x branch April 10, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants