Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] Update GT: Update all L1T tags #21137

Merged
merged 5 commits into from Nov 20, 2017

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Nov 2, 2017

Summary of changes in Global Tags

RunI data

RunII data

Upgrade

2017_MC

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21137/1772

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24139/console Started: 2017/11/02 16:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa
L1Trigger/Configuration

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mulhearn, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @tocheng, @Martin-Grunewald, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21137/1774

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24140/console Started: 2017/11/02 16:56

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Pull request #21137 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mulhearn, @lpernie can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented Nov 15, 2017

@jfernan2 Thanks !

@davidlange6
Copy link
Contributor

please test
(comparison differences seem to be fake)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24463/console Started: 2017/11/15 19:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21137/24463/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 630 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2832924
  • DQMHistoTests: Total failures: 1957
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2830787
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.17000000006 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Nov 16, 2017

@davidlange6 can this PR be merged please? With this we will have this duplicity removed for L1T fake EMTF params and we can arrange the queues accordingly. Thanks.

@arunhep
Copy link
Contributor

arunhep commented Nov 20, 2017

@davidlange6 can this PR be merged please?
we have few other updates lined up for 10.0.X.
Thanks.

@davidlange6
Copy link
Contributor

i didn't have a chance to understand the physics changes on Friday. Do you expect them?

@arunhep
Copy link
Contributor

arunhep commented Nov 20, 2017

@davidlange6 we don't expect physics changes because of these updates.
these updates are mainly for L1T caloParams and BMTF and EMTF parameters.

And i don't see any in 2017, 2018 MC.
for data wf 136.731 I see only changes in the L1T directory : https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_0_X_2017-11-15-1100+21137/23739/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/L1T.html

can you please point me to the changes which you may have seen and not directly understood from these updates?

@kkotov
Copy link
Contributor

kkotov commented Nov 20, 2017

Perhaps, @rekovic can give a better summary of the DQM differences, but as far as I remember, for the L1T, DQM results for data are expected to be different between new and old GTs. We've finally switched to configuring L1T from O2O tags in CondDB as opposed to static pythons as it was before.

@davidlange6
Copy link
Contributor

davidlange6 commented Nov 20, 2017 via email

@davidlange6
Copy link
Contributor

looks like 2017B data, 2016B data

@rekovic
Copy link
Contributor

rekovic commented Nov 20, 2017

@davidlange6

When we introduced the NoHackConditions originally we knew that we were missing some BMTF Conditions from the GT. #20871 (comment)
Then, we had ~2000 comparison histograms with changes #20871 (comment). The report is now old, and cannot access the histograms.

Now, this PR provides the missing BMTF conditions, and we now have ~2000 histograms showing differences. The numbers make sense. Need to look at the histograms.

@rekovic
Copy link
Contributor

rekovic commented Nov 20, 2017

All the differences I found have to do with uGMT (i.e. Muons), fund in either L1TEMU or L1T
folders.

An example being data vs emul comparisons in L1TEMU
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_0_X_2017-11-15-1100+21137/23739/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/L1TEMU_L1TdeStage2uGMT_data_vs_emulator_comparison.html

Another example is change in L1T/L1TStage2uGMT
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_0_X_2017-11-15-1100+21137/23739/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/L1T_L1TStage2uGMT.html

As usual, we need to look at the higher statistics RelVal samples to finally validate the new release.
But from what I see from comparisons, the observed changes are at the right place. So,

+1

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants