New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hcal relval update 9_X_Y digi amplitude #21144
Hcal relval update 9_X_Y digi amplitude #21144
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21144/1781 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21144/1781/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @bcmcms for master. It involves the following packages: Validation/HcalDigis @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@kmaeshima, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. |
@bcmcms - please, don't hesitate to remind reviewers that the PR stays idle for quite some time. |
Thanks! Yes, hopefully this PR can be signed off soon. |
@kmaeshima, @vanbesien, @vazzolini, @dmitrijus ping... |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
“Updated digi amplitude plots to support the phase1 upgrade digis' expanded ranges.”