Add method to return the significance of a track inside a Det

[VinInn]

With this PR we add to Bounds a method that returns the significance of a track inside a Det
(negative if inside, positive if outside)
We add this information to "MIssingHIts" in place of the "estimator".

The idea is to later use this information to try to identify tracks that miss a Det because they pass between the gap among two of them: this has been seen occurring in particular in the Inner Pixel for both Phase1 and Phase2.

This PR just adds the capability, does not make any use of it.
No regression expected. It does recompile the universe.
Any future use of this information is expected to create regression: so we prefer to start from an IB
already including this basic mods that trigger major recompilation.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21147/1788

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21147/1788/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-21147/1788/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21147/1789

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

DataFormats/GeometrySurface
TrackingTools/MeasurementDet

@perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24150/console Started: 2017/11/03 10:42

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[VinInn]

Thanks @slava77 for the suggestion. edited in place

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21147/1962

[cmsbuild]

Pull request #21147 was updated. @perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please check and sign again.

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24384/console Started: 2017/11/12 16:11

[slava77]

On 11/12/17 1:22 PM, Vincenzo Innocente wrote: Thanks @slava77 <https://github.com/slava77> for the suggestion. edited in place

Thank you. BTW, what is the editing "in place"? Is it from the web interactively? I was always wondering if that works.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21147 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbqzG4VbrC_fZ619ElLlhEx9G9E0Xks5s1uMEgaJpZM4QQ1Ob>.

[VinInn]

On 12 Nov, 2017, at 2:02 PM, Slava Krutelyov ***@***.***> wrote: BTW, what is the editing "in place"? Is it from the web interactively? I was always wondering if that works.

yes, I do it often for small changes and always for .md I was hoping to edit all files in one go, instead ended up in editing them one by one. Sorry for the commit spam! v.

[cmsbuild]

-1

Tested at: c83121b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d1d8d45
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d1d8d45
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21147/24384/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832699
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832520
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.89000000013 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[slava77]

+1

for #21147 c83121b

• significanceInside method for bound surfaces based on the input position and uncertainty. This information is saved with invalid hits in the track trajectory LayerMeasurements::addInvalidMeas; it does not affect monitored quantities.
• jenkins tests pass and comparisons show no differences

[davidlange6]

merge