Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcalCondObjectContainer.h: remove not defined inline function warning #2115

Merged
merged 1 commit into from Feb 13, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 21, 2014

The warning is produced by ROOT6 run-time (Cling/Clang).

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The warning is produced by ROOT6 run-time (Cling/Clang).

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_1_X.

EcalCondObjectContainer.h: remove not defined inline function warning

It involves the following packages:

CondFormats/EcalObjects

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2115/27/summary.html

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@apfeiffer1
Copy link
Contributor

-1
as tests are failing ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

@rcastello
Copy link

+1

@ktf
Copy link
Contributor

ktf commented Feb 13, 2014

Andreas rejection was due to tests failing (for a different reason). Now they work. Bypassing his signature. @apfeiffer1 complain if not ok.

ktf added a commit that referenced this pull request Feb 13, 2014
Misc fixes -- EcalCondObjectContainer.h: remove not defined inline function warning
@ktf ktf merged commit 090391c into cms-sw:CMSSW_7_1_X Feb 13, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants