New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error in EvtGenInterface.cc #21169
Conversation
Use `bool empty() const;` method from `std::string` to check if it's empty. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @davidlt for master. It involves the following packages: GeneratorInterface/EvtGenInterface @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Use
bool empty() const;
method fromstd::string
to check if it'sempty.
This failed to compile in
CMSSW_10_0_ROOT6_X_2017-11-04-0900
.Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch