New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ASan + -O0 compilation in CondFormats/EcalObjects #21171
Conversation
While working on ASan + -O0 build I kept getting: CondFormats/EcalObjects/interface/EcalCondObjectContainer.h:82:17: error: control reaches end of non-void function [-Werror=return-type] I don't see how this could be the case, but the following change should be safe also and avoids this issue. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @davidlt for master. It involves the following packages: CondFormats/EcalObjects @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
While working on ASan + -O0 build I kept getting:
I don't see how this could be the case, but the following change should
be safe also and avoids this issue.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch