Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASan + -O0 compilation in CondFormats/EcalObjects #21171

Merged
merged 1 commit into from Nov 7, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Nov 5, 2017

While working on ASan + -O0 build I kept getting:

CondFormats/EcalObjects/interface/EcalCondObjectContainer.h:82:17:
error: control reaches end of non-void function [-Werror=return-type]

I don't see how this could be the case, but the following change should
be safe also and avoids this issue.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

While working on ASan + -O0 build I kept getting:

    CondFormats/EcalObjects/interface/EcalCondObjectContainer.h:82:17:
    error: control reaches end of non-void function [-Werror=return-type]

I don't see how this could be the case, but the following change should
be safe also and avoids this issue.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21171/1830

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

A new Pull Request was created by @davidlt for master.

It involves the following packages:

CondFormats/EcalObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24192/console Started: 2017/11/05 18:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21171/24192/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2900266
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2900094
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Nov 7, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5791322 into cms-sw:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants