Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T offine DQM changes for pp reference run - 92x #21191

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Nov 6, 2017

Backport of #21188

To make the L1T offline DQM work for the pp reference run the trigger paths used must be adapted for the pp reference run HLT menu.

This PR includes commit d5ae3a6 from PR #21070 to get the era "Run2_2017_ppRef".

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

Configuration/DataProcessing
Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences
DQMOffline/L1Trigger

@prebello, @vazzolini, @dmitrijus, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @rekovic, @franzoni, @jfernan2, @GurpreetSinghChahal, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Nov 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24217/console Started: 2017/11/06 22:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21191/24217/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2160427
  • DQMHistoTests: Total failures: 29699
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2130556
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 9 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Pull request #21191 was updated. @prebello, @vazzolini, @dmitrijus, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @rekovic, @franzoni, @jfernan2, @GurpreetSinghChahal, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Pull request #21191 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please check and sign again.

@rekovic
Copy link
Contributor

rekovic commented Nov 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24266/console Started: 2017/11/08 12:26

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 043c3fe into cms-sw:CMSSW_9_2_X Nov 8, 2017
@thomreis thomreis deleted the l1t_offline_dqm_changes_for_ppref_run_92x branch November 8, 2017 12:21
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21191/24266/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2162937
  • DQMHistoTests: Total failures: 44282
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2118483
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0 ( 0 files compared)
  • Checked 94 log files, 8 edm output root files, 23 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants