Removed unnecessary caching for consumes failures #21194
Conversation
Removed the caching of requests which were not registered for consumes since now we trigger a fatal exception in that case.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
This gets rid of an unlikely thread safety issue which would happen if a module tries to get a data product for which it did not call 'consumes'. This code dates back to before that was a fatal exception. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Removed the caching of requests which were not registered for consumes since now we trigger a fatal exception in that case.