Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty entry from phase2 harvesting list #21202

Merged
merged 1 commit into from Nov 10, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Nov 7, 2017

Step4 in Phase2 workflows was printing this message:

 is not a possible harvesting type. Available are [...]

where [...] was a very long list of all harvesting sequences. I found this was caused by the inclusion of an empty string in the phase2Validation lists, which is now fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21202/1854

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/Applications
Validation/Configuration

@perrotta, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @swertz, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21202/1855

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Pull request #21202 was updated. @perrotta, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @vanbesien can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24252/console Started: 2017/11/07 17:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21202/24252/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2755261
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2755091
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor

civanch commented Nov 8, 2017

+1

@slava77
Copy link
Contributor

slava77 commented Nov 8, 2017

+1

for #21202 0f438b0

  • tangential to reco (technical change in Validation/Configuration)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 91c4b49 into cms-sw:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants